Unblacklist user_query_keys_test for synapse#198
Merged
DMRobertson merged 1 commit intomasterfrom Aug 23, 2021
Merged
Conversation
After my changes in matrix-org/synapse#10593
clokep
approved these changes
Aug 23, 2021
Member
clokep
left a comment
There was a problem hiding this comment.
Seems reasonable since the tests pass. 😄
Contributor
Author
|
Hmmm. I can't see TestKeysQueryWithDeviceIDAsObjectFails in the CI run anywhere---does that mean this test isn't getting run today (even for dendrite?) |
Contributor
Author
Can see it in the raw logs---just couldn't search for it with Ctrl-F while viewing the output from github actions. Assuming it's a PICNIC on my part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After my changes in matrix-org/synapse#10593