Update the Synapse Worker configuration with new base image name and worker configuration#105
Merged
anoadragon453 merged 6 commits intomasterfrom May 21, 2021
Merged
Conversation
We've removed '*' as it stopped making sense after we started allowing multiple instances of the same worker to be specified. This list of workers is ripped from SyTest.
erikjohnston
approved these changes
Apr 26, 2021
Member
erikjohnston
left a comment
There was a problem hiding this comment.
I think this broadly matches current sytest config
Member
Author
|
After looking at the diff again, I don't think this really needs a review from a Complement perspective... |
Member
|
@anoadragon453 is this ready to merge? |
Member
Author
|
Yes apologies for the delay. I just wanted to test the whole thing end-to-end before merging but got hung up on the I don't think these changes are going to be modified any further however, so we can merge this bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Complement's Synapse worker-flavoured docker image in a few ways:
synapse:workerstosynapse-workers, as it's built from a separate Dockerfile from the basematrixdotorg/synapseimage.SYNAPSE_WORKERSenv var name toSYNAPSE_WORKER_TYPES*functionality after adding sharding capabilities. The worker configuration mirrors that of sytest.These changes grew out of this PR on Synapse which changed the base image.
I'd ideally like feedback from the Synapse team on the chosen worker configuration.