Closed
Conversation
This was referenced Jun 18, 2017
Merged
4ebcc97 to
017aeed
Compare
ffe84ac to
b776786
Compare
(Apparently the version parsing can sometimes fail on Travis.)
gdk_window_process_updates is deprecated since GDK 3.22. Agg animations run fine without it, and removing it makes mpl_cairo animations faster. Being drawable is synonym to being mapped and visible.
Vector surfaces do not report their extents, so we need to pass them in manually.
Contributor
Author
|
I would really appreciate if this could make it in 2.2 because it is more or less a prerequisite for me to make a first release of mplcairo (i.e. with a working GUI backend). So labeling it as such, but feel free to retag if you think this is too hard. |
Member
|
@anntzer I'd be OK w/ it if it were more self contained. What are good tests that the changes in I agree it would be very nice to see this in for 2.2. It seems that cairo is a great way forward, particularly as it can be used to drive openGL if I understand correctly. |
6 tasks
Contributor
Author
|
Splitting out the nonessential parts... |
This was referenced Jan 9, 2018
Contributor
Author
|
Superseded by #10210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a cairo based renderer for Qt canvas, under the name "Qt4Cairo"/"Qt5Cairo". Test e.g. by setting the MPLBACKEND environment variable to
qt4cairo/qt5cairo.The following commits implement the Qt5Cairo backend, then the Qt4Cairo backend, and redistributes relevant code chunks between the various
backend_qt*modules in order to maximize code reuse, and then update the docs. I would suggest restricting comments for this PR to the diff of these last commits.Note that because of the way the cairo backend is currently written, all the drawing occurs during the Qt draw event, instead of being buffered before it as in Agg. The third party mplcairo backend works around this limitation, but this PR is still useful to cleanly separate the windowing and rendering parts of the code.
PR Checklist
-> see test_backends_interactive.py