Fix ps export of colored hatches with no linewidth#22794
Merged
Conversation
d4b89fd to
86a08ee
Compare
anntzer
reviewed
Apr 7, 2022
anntzer
approved these changes
Apr 7, 2022
Contributor
anntzer
left a comment
There was a problem hiding this comment.
preferably with the removal of glyph embedding mentioned above.
86a08ee to
9a11893
Compare
timhoffm
approved these changes
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #22792
Color was not set when linewidth = 0. This adds a condition that either linewidth is non-zero or there are hatches.
I'm having problem adding a test for this as the generated eps-files differ in size when converted to png.Edit: the test code was more clever than me...PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).