Skip to content

Move widget functions into matplotlib.testing.widgets.#17030

Merged
tacaswell merged 3 commits intomatplotlib:masterfrom
SidharthBansal:move_widget_functions_into_testing
Apr 30, 2020
Merged

Move widget functions into matplotlib.testing.widgets.#17030
tacaswell merged 3 commits intomatplotlib:masterfrom
SidharthBansal:move_widget_functions_into_testing

Conversation

@SidharthBansal
Copy link
Copy Markdown
Contributor

@SidharthBansal SidharthBansal commented Apr 4, 2020

PR Summary

Fixes #7372, move widget functions into matplotlib.testing.widgets.

Co-authored-by: @dakotablair
Closes #9905

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@SidharthBansal

This comment has been minimized.

Sign in to view
@anntzer
Copy link
Copy Markdown
Contributor

anntzer commented Apr 4, 2020

I think that test has been failing for most of the day, we just need to investigate it separately...

@SidharthBansal

This comment has been minimized.

Sign in to view
@SidharthBansal SidharthBansal mentioned this pull request Apr 5, 2020
Closed
@tacaswell tacaswell added this to the v3.3.0 milestone Apr 13, 2020
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Apr 13, 2020

We have a preference for rebasing onto master rather than merging master in to the feature branch.

Could you rebase (and force push) this @SidharthBansal ? The other option is we can squash merge.

tacaswell
tacaswell approved these changes Apr 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo squashing out the merge from master.

@SidharthBansal SidharthBansal force-pushed the move_widget_functions_into_testing branch 3 times, most recently from 47957b9 to 5e9ec0c Compare April 13, 2020 23:34
@SidharthBansal
Copy link
Copy Markdown
Contributor Author

SidharthBansal commented Apr 13, 2020

I rebased and forced push. Thanks!

QuLogic
QuLogic previously requested changes Apr 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are nice-to-have; Python 2 must go.

@SidharthBansal SidharthBansal force-pushed the move_widget_functions_into_testing branch 16 times, most recently from 21e1598 to 5ada649 Compare April 16, 2020 19:33
@SidharthBansal SidharthBansal force-pushed the move_widget_functions_into_testing branch from 5ada649 to d3750f7 Compare April 16, 2020 21:38
@SidharthBansal SidharthBansal requested a review from QuLogic April 17, 2020 05:39
dstansby
dstansby reviewed Apr 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably get a changelog entry (since it's technically a breaking API change) in doc/api/api_changes

QuLogic
QuLogic reviewed Apr 20, 2020
View reviewed changes
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Apr 20, 2020

It's not really a breaking API change, as this is all new API.

SidharthBansal and others added 2 commits April 21, 2020 19:38
@SidharthBansal @QuLogic
Update lib/matplotlib/testing/widgets.py
e83e0b4 
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@SidharthBansal @QuLogic
Update lib/matplotlib/testing/widgets.py
e34f406 
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@SidharthBansal
Copy link
Copy Markdown
Contributor Author

SidharthBansal commented Apr 21, 2020

Thanks @QuLogic. I have completed the suggested changes. :)

@QuLogic QuLogic dismissed their stale review April 21, 2020 20:32

Removed Python 2

@tacaswell tacaswell merged commit 912e814 into matplotlib:master Apr 30, 2020
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Apr 30, 2020

🐑 I miss read the UI and thought @QuLogic had previously approved it, but that was me so I merged this with one review, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments

@dstansby dstansby dstansby left review comments

@tacaswell tacaswell tacaswell approved these changes

Assignees

No one assigned

Labels

topic: widgets/UI

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

Moving get_ax and do_event to testing

5 participants

@SidharthBansal @anntzer @tacaswell @QuLogic @dstansby