relax two test tolerances on x86_64#16002
relax two test tolerances on x86_64#16002timhoffm merged 2 commits intomatplotlib:masterfrom nschloe:relax-test-tolerance
Conversation
|
flake8 errors: |
timhoffm
left a comment
There was a problem hiding this comment.
I'm a bit uneasy relaxing tolerances just because "then it works". If it worked before and does not work now, we should at least have a rough idea what changed. Can you provide the diff image of the failed tests?
OTOH this was done already for aarch64, so relaxing is maybe not too bad?
I'm with you there. When running the tests locally I noticed those tests are failing with the same tolerance as the aarch64 exceptions, so I threw that curve ball at you. I would guess that the exceptions aren't related to the architecture but the version of some dependency, perhaps a few layers down. Might be hard to figure out. |
|
Can you provide the diff image of the failed tests? They should be in the folder |
|
Also, do you still observe the need for this after |
Yes. Here are the plots for the failing
And for
|
timhoffm
left a comment
There was a problem hiding this comment.
Thanks for the images! Both are subpixel positioning issues. I think it's ok to increase the tolerance in these cases without digging into the actual difference in the environment.
QuLogic
left a comment
There was a problem hiding this comment.
These fail for me too, but I never had time to investigate. So if people are okay with bumping the tolerance, I'm happy to see two less failures.
When running the tests locally on
x86_64, I had to relax two tolerances to the same value asaarch64.This is on Ubuntu 20.04, so perhaps the reason why no one else has run into this before is an upgraded version in the dependency stack.