Move {setup,install}_requires from setupext.py to setup.py.#13542
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom May 26, 2019
Merged
Move {setup,install}_requires from setupext.py to setup.py.#13542tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
The Numpy class in setupext.py serves two purposes: declare a setup_requires and an install_requires on numpy, and provide a add_flags() (effectively static) method to link extension modules to numpy. Instead, we can just merge the setup and install_requires together with all other install_requires, and move all of them to setup.py (deleting the machinery to grab setup_requires and install_requires from multiple places), and make the add_flags() method a free function (add_numpy_flags()).
6 tasks
efiring
approved these changes
May 26, 2019
Member
efiring
left a comment
There was a problem hiding this comment.
I'm not a setup expert by any means, but this looks good to me.
timhoffm
approved these changes
May 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Numpy class in setupext.py serves two purposes: declare a
setup_requires and an install_requires on numpy, and provide a
add_flags() (effectively static) method to link extension modules to
numpy.
Instead, we can just merge the setup and install_requires together
with all other install_requires, and move all of them to setup.py
(deleting the machinery to grab setup_requires and install_requires
from multiple places), and make the add_flags() method a free function
(add_numpy_flags()).
PR Summary
PR Checklist