Merged
Conversation
Mostly so that Matplotlib doesn't depend *transitively* on six either :) - six.iteritems() -> dict.items(): OK even on Py2, we directly consume the iterator/list with reduce anyways, and I doubt that the perfomance change is measurable. - six.moves.zip() could have been replaced with builtin zip() on both Py2 and Py3 because we always exhaust the iterator immediately anyways, but it also acts as a lookup key in `Cycler.__len__` so I decided to just play it safe and have a conditional import (on Py2, six.moves.zip is an alias for itertools.zip). Also added new .pytest_cache directory to gitignore.
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 177 179 +2
Branches 50 51 +1
=====================================
+ Hits 177 179 +2
Continue to review full report at Codecov.
|
timhoffm
approved these changes
Aug 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly so that Matplotlib doesn't depend transitively on six either :)
(doesn't break Py2 compat)
the iterator/list with reduce anyways, and I doubt that the perfomance
change is measurable.
Py2 and Py3 because we always exhaust the iterator immediately
anyways, but it also acts as a lookup key in
Cycler.__len__so Idecided to just play it safe and have a conditional import (on Py2,
six.moves.zip is an alias for itertools.zip).
Also added new .pytest_cache directory to gitignore.