Closed
Conversation
added flag -i to support reversing ordering of covered functions
olurin
reviewed
Jul 11, 2019
olurin
left a comment
There was a problem hiding this comment.
@Blackmage89 Good Idea! the package change might be the reason why this PR is not merged
| import ( | ||
| "flag" | ||
| "github.com/matm/gocov-html/cov" | ||
| "github.com/Blackmage89/gocov-html/cov" |
There was a problem hiding this comment.
Package name changed to github.com/Blackmage89/gocov-html/cov from github.com/matm/gocov-html/cov.
This was referenced Mar 8, 2023
Owner
|
Thanks a lot for your contribution @Blackmage89. Merged in #46. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, it would be great if you could merge this if it is not a problem.
Only one thing to watch out for is the import path in gocov-html.go, i had to change it to my local repo, after the merge you should revert it to the original one.
thank you.