Skip to content

Removed vhosts for ws and replaced cors with origins#574

Merged
cffls merged 2 commits into
developfrom
pratik-flag
Nov 3, 2022
Merged

Removed vhosts for ws and replaced cors with origins#574
cffls merged 2 commits into
developfrom
pratik-flag

Conversation

@pratikspatil024

@pratikspatil024 pratikspatil024 commented Nov 3, 2022

Copy link
Copy Markdown
Member

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov-commenter

codecov-commenter commented Nov 3, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 56.78% // Head: 56.76% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (aa0a757) compared to base (be3f297).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #574      +/-   ##
===========================================
- Coverage    56.78%   56.76%   -0.02%     
===========================================
  Files          606      606              
  Lines        70282    70275       -7     
===========================================
- Hits         39907    39890      -17     
- Misses       26944    26960      +16     
+ Partials      3431     3425       -6
Impacted Files Coverage Δ
internal/cli/server/config.go 73.04% <100.00%> (-0.07%) ⬇️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
core/state/trie_prefetcher.go 74.80% <0.00%> (-3.82%) ⬇️
les/pruner.go 60.71% <0.00%> (-3.58%) ⬇️
consensus/ethash/sealer.go 78.64% <0.00%> (-2.92%) ⬇️
les/utils/exec_queue.go 88.88% <0.00%> (-2.78%) ⬇️
consensus/ethash/algorithm.go 90.13% <0.00%> (-1.32%) ⬇️
les/odr.go 89.02% <0.00%> (-1.22%) ⬇️
p2p/peer.go 74.62% <0.00%> (-1.00%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pratikspatil024 pratikspatil024 marked this pull request as ready for review November 3, 2022 11:21
@pratikspatil024 pratikspatil024 changed the title Removed vhosts for ws and added replaced cors with origins Removed vhosts for ws and replaced cors with origins Nov 3, 2022
@pratikspatil024 pratikspatil024 mentioned this pull request Nov 3, 2022
Merged
@cffls cffls merged commit 1ab225c into develop Nov 3, 2022
@cffls cffls mentioned this pull request Nov 3, 2022
Merged
cffls pushed a commit to cffls/bor that referenced this pull request Nov 3, 2022
@pratikspatil024 @cffls
Removed vhosts for ws and replaced cors with origins (0xPolygon#574)
8cc0b25 
* removed vhosts for ws and added replaced cors with origins

* updated script
@cffls cffls mentioned this pull request Nov 3, 2022
Merged
15 tasks
@pratikspatil024 pratikspatil024 deleted the pratik-flag branch November 4, 2022 03:02
@pratikspatil024 pratikspatil024 mentioned this pull request Nov 4, 2022
Merged
cffls added a commit that referenced this pull request Nov 4, 2022
@cffls
Merge pull request #575 from cffls/qa
b1f4196 
Removed vhosts for ws and replaced cors with origins (#574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manav2401 manav2401 manav2401 approved these changes

@cffls cffls cffls approved these changes

@0xsharma 0xsharma Awaiting requested review from 0xsharma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pratikspatil024 @codecov-commenter @manav2401 @cffls