Skip to content
This repository was archived by the owner on Jan 21, 2025. It is now read-only.

[PERF] AsyncEventSource writes multiple events per tcp send, including partial events that straddle buffers; Improvement: don't hold onto event items until ack, immediately remove them from queue #92

Merged
mathieucarbou merged 1 commit into from
Sep 4, 2024
Merged

[PERF] AsyncEventSource writes multiple events per tcp send, including partial events that straddle buffers; Improvement: don't hold onto event items until ack, immediately remove them from queue #92

mathieucarbou merged 1 commit into from
Sep 4, 2024

Conversation

@mathieucarbou
Copy link
Owner

@mathieucarbou mathieucarbou commented Sep 4, 2024 •
edited
Loading

Copy of PR esphome/ESPAsyncWebServer#41 from @nkinnan

See the above PR for discussion.

@mathieucarbou
Bugfix: AsyncEventSource writes multiple events per tcp send, includi…
ac748ef 
…ng partial events that straddle buffers; Improvement: don't hold onto event items until ack, immediately remove them from queue

Copy of esphome/ESPAsyncWebServer#41
@mathieucarbou mathieucarbou self-assigned this Sep 4, 2024
@mathieucarbou mathieucarbou linked an issue Sep 4, 2024 that may be closed by this pull request
AsyncEventSource writes multiple events per tcp send; Improvement: don't hold onto event items until ack, immediately remove them from queue #91
Closed
@mathieucarbou mathieucarbou mentioned this pull request Sep 4, 2024
Merged
@mathieucarbou mathieucarbou changed the title AsyncEventSource writes multiple events per tcp send, including partial events that straddle buffers; Improvement: don't hold onto event items until ack, immediately remove them from queue [PERF] AsyncEventSource writes multiple events per tcp send, including partial events that straddle buffers; Improvement: don't hold onto event items until ack, immediately remove them from queue Sep 4, 2024
@mathieucarbou mathieucarbou merged commit 2d6e140 into main Sep 4, 2024
@mathieucarbou mathieucarbou deleted the sse branch September 4, 2024 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vortigont vortigont Awaiting requested review from vortigont

Assignees

@mathieucarbou mathieucarbou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AsyncEventSource writes multiple events per tcp send; Improvement: don't hold onto event items until ack, immediately remove them from queue

2 participants

@mathieucarbou