This repository was archived by the owner on Jan 21, 2025. It is now read-only.
(perf) Remove "interesting headers" to fasten request processing (replaced with removeHeadersExcept)
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50ff2d9 to
185fe00
Compare
185fe00 to
095df77
Compare
removeHeadersExcept)
vortigont
reviewed
Sep 11, 2024
Collaborator
vortigont
left a comment
There was a problem hiding this comment.
one small remark so far
095df77 to
9ff9374
Compare
All headers are already parsed: interesting headers allowed to cleanup parsed headers to only keep interesting ones during request processing. Removing "interesting headers" support will keep these parsed headers in heap memory during request processing before being freed at the end of the request. If you really need to cleanup some headers to get more heap space during request processing, use a middleware and removeHeadersExcept(names) to remove some.
94f7453 to
b4460a2
Compare
Owner
Author
|
I will merge this one today: this one is not as important as the middleware one and is quite simple. |
Owner
Author
|
And in case you see something, we'll PR a fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All headers are already parsed: interesting headers allowed to cleanup parsed headers to only keep interesting ones during request processing.
Headers are anyway all cleaned after request processing.
This removal helps reduce flash size and heap usage (on vector less).