Fix replacement-js flag when referencing matched groups when matching multiple files #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! |
Owner
|
The CICD worked smoothly, but I’m getting an error in my local setup, which is odd. I’ll need to investigate why this is happening. I’ll publish a new version as soon as possible, but I’ll probably only have time to look into it over the weekend. |
Owner
|
Turns out with async read + transformation of files you can't predict the order of output. Complexity does really grow exponentially. 🎉 Things got sorted and your awesome contribution is out in the wild now as part of v7.1.11 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue #512.
When using dynamic replacement with multiples files being processed, the replacement value was being overridden after the first processed file.
This fix separates the dynamic processing replacement from the standard replacement string as to not lose its value when parsing multiple files with the replacement-js flag.
Two testing scenarios were added to test these instances.