Pass process_entries arguments to solid_compat in MaterialsProjectAqueousCompatibility#4589
Merged
shyuep merged 8 commits intomaterialsproject:masterfrom Feb 19, 2026
Merged
Conversation
…tAqueousCompatibility` Signed-off-by: lkkmpn <git@lkkmpn.nl>
process_entries argument to solid_compat in MaterialsProjectAqueousCompatibilityprocess_entries arguments to solid_compat in MaterialsProjectAqueousCompatibility
Member
|
Pls add a unit test for the new behavior. |
Contributor
Author
|
I have added a unit test focusing on the |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
MaterialsProjectAqueousCompatibilityclass has asolid_compatargument for preprocessing, but currently only a subset of arguments to the aqueous compatibility'sprocess_entriesmethod are passed on to that of thesolid_compat. This PR changes this so that all arguments are passed on, for more clear behavior. For instance, currently, if a user setson_error='raise'on the aqueous compatibility object, the solid entries compatibility object would still ignore all errors, which can be confusing.