Skip to content

VolumetricData.copy preserve subclass type#4526

Merged
shyuep merged 2 commits intomaterialsproject:masterfrom
DanielYang59:fix-vol-data-copy
Oct 21, 2025
Merged

VolumetricData.copy preserve subclass type#4526
shyuep merged 2 commits intomaterialsproject:masterfrom
DanielYang59:fix-vol-data-copy

Conversation

@DanielYang59
Copy link
Contributor

Summary

@DanielYang59 DanielYang59 force-pushed the fix-vol-data-copy branch 2 times, most recently from 4baa178 to 91c3eba Compare October 20, 2025 10:13
@DanielYang59 DanielYang59 marked this pull request as ready for review October 20, 2025 10:48
@DanielYang59 DanielYang59 changed the title VolumetricData.copy use dynamic type to preserve subclass type VolumetricData.copy preserve subclass type Oct 20, 2025
@shyuep shyuep merged commit 4103783 into materialsproject:master Oct 21, 2025
44 checks passed
@shyuep
Copy link
Member

shyuep commented Oct 21, 2025

Thanks.

@DanielYang59 DanielYang59 deleted the fix-vol-data-copy branch October 21, 2025 15:04
@DanielYang59
Copy link
Contributor Author

no problem ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard-coded type of the returned object of VolumetricData.copy breaks polymorphism

2 participants