Conversation
3e8c458 to
68539ab
Compare
| assert procar.get_occupation(0, "s")[Spin.up] == approx(0.35381249999999997) | ||
| assert procar.get_occupation(0, "p")[Spin.up] == approx(1.19540625) | ||
| with pytest.raises(ValueError, match="'m' is not in list"): | ||
| with pytest.raises(ValueError, match="not in list"): |
There was a problem hiding this comment.
Python 3.14 changed the error message:
>>> uv run -p 3.13 python -c '["a"].index(1)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
["a"].index(1)
~~~~~~~~~~~^^^
ValueError: 1 is not in list
>>> uv run -p 3.14 python -c '["a"].index(1)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
["a"].index(1)
~~~~~~~~~~~^^^
ValueError: list.index(x): x not in list
e6f96a3 to
41206f0
Compare
| python: "3.13" | ||
| resolution: lowest-direct | ||
| python: "3.14" | ||
| resolution: highest |
There was a problem hiding this comment.
I think we should test highest resolution in Ubuntu (likely mostly used) as it's the default strategy, so it would be closer to what most users get:
By default, uv tries to use the latest version of each package
| "@deprecated", | ||
| "def __repr__", | ||
| "except ImportError:", | ||
| "if TYPE_CHECKING:", |
There was a problem hiding this comment.
It's now excluded by default:
A branch just for type checkers: if TYPE_CHECKING:.
Added in version 7.10.0: the ... and TYPE_CHECKING defaults.
05e4016 to
ae9fa91
Compare
38be5b2 to
a9ff0be
Compare
remove self explanatory comment
xfail for netcdf4 in ubuntu CI
fail back to 3.13 for lint as pyright is not installable
revert win to 3.11 for now (cannot recreate locally)
resolve to highest in Ubuntu
fix different err msg in 3.14
➜ temp uv run -p 3.13 test_index.py
Traceback (most recent call last):
File "/Users/yang/developer/temp/test_index.py", line 1, in <module>
print(["a"].index(1))
~~~~~~~~~~~^^^
ValueError: 1 is not in list
➜ temp uv run -p 3.14 test_index.py
Traceback (most recent call last):
File "/Users/yang/developer/temp/test_index.py", line 1, in <module>
print(["a"].index(1))
~~~~~~~~~~~^^^
ValueError: list.index(x): x not in list
skip netcdf4 in 3.13
skip more py 3.14 incompatible deps
matcalc seems installable on python 3.13 and 3.14
skip more packages that doesn't support 3.14 now
remove pin for pure python analysis-alloy
remove comment
drop openai pin
unblock h5py
unpin netcdf4
597ae75 to
49d0c1e
Compare
|
@DanielYang59 Thank you for this. I'm comfortable merging given that the only dependencies that do not yet support Python 3.14 are optional and you have cleanly marked these dependencies with |
|
Hi @mkhorton no problem at all. Sure we could go with this and I would add another PR once |
|
Thanks. |
[tool.pdm.dev-dependencies]section from pyproject.toml (seems like thepdm.lockwas removed in fb6ba71?)hiphive)phonopy)