Update periodic table data: "Common oxidation states", "critical temperature" and "electrical resistivity"#4515
Merged
shyuep merged 9 commits intomaterialsproject:masterfrom Oct 16, 2025
Conversation
DanielYang59
commented
Oct 8, 2025
| assert str(val.unit) == "W K^-1 m^-1" | ||
| val = al.electrical_resistivity | ||
| assert val == approx(2.7e-08) | ||
| assert val == approx(2.65e-08) |
Contributor
Author
There was a problem hiding this comment.
c77d279 to
8a03a7c
Compare
DanielYang59
commented
Oct 8, 2025
| n_electron_sp = sum(orb[-1] for orb in Species(el.symbol, ox).full_electronic_structure) | ||
| # Some species miss `full_electronic_structure` data | ||
| try: | ||
| n_electron_sp = sum(orb[-1] for orb in Species(el.symbol, ox).full_electronic_structure) |
Contributor
Author
There was a problem hiding this comment.
Some newly added Species (via "common oxidation state") don't have electronic structure data:
C -3
C -2
C -1
C 1
C 2
C 3
Kr 2
Xe 2
Xe 4
Xe 6
Re 7
8a03a7c to
831405b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update periodic table data: "Common oxidation states", "critical temperature" and "electrical resistivity"
Make them consistent with wikipedia source