Overwrite __rtruediv__ for FloatWithUnit, fix ArrayWithUnit loses unit_type when unpickled#4496
Merged
shyuep merged 10 commits intomaterialsproject:masterfrom Sep 16, 2025
Merged
Conversation
29dcf97 to
0a4300f
Compare
__rtruediv__ for FloatWithUnit __rtruediv__ for FloatWithUnit
0a4300f to
ee4902a
Compare
c545ad0 to
58bf77c
Compare
__rtruediv__ for FloatWithUnit__rtruediv__ for FloatWithUnit, fix ArrayWithUnit loses unit_type when unpickled
Member
|
Thanks,. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FloatWithUnitshould overwrite__rtruediv__#4495ArrayWithUnitbehaviourArrayWithUnitlosesunit_typecore.units, https://app.codecov.io/gh/materialsproject/pymatgen/blob/master/pymatgen%2Fcore%2Funits.py