Replace linear_assignment with scipy linear_sum_assignment #4490
Merged
shyuep merged 3 commits intomaterialsproject:masterfrom Sep 3, 2025
Merged
Replace linear_assignment with scipy linear_sum_assignment #4490shyuep merged 3 commits intomaterialsproject:masterfrom
linear_assignment with scipy linear_sum_assignment #4490shyuep merged 3 commits intomaterialsproject:masterfrom
Conversation
8c6f336 to
0997fb9
Compare
Member
|
Can you confirm that the scipy version actually is faster? The numbers don't seem to bear that out? |
Contributor
Author
As far as I could tell our version performs almost identically as the scipy version (tested both on WSL2 ubuntu 24.04 AMD64 and my MacOS ARM64 machines), this replacement was not really intended for speed but freeing pymatgen from maintaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linear_assignmentwithscipylinear_sum_assignmentBenchmark
WSL2 Ubuntu 24.04 (AMD64)
Master branch:
Current branch:
script: