Fix jdftx.outputs usage of 3.11+ only syntax#4484
Merged
shyuep merged 5 commits intomaterialsproject:masterfrom Aug 21, 2025
Merged
Fix jdftx.outputs usage of 3.11+ only syntax#4484shyuep merged 5 commits intomaterialsproject:masterfrom
shyuep merged 5 commits intomaterialsproject:masterfrom
Conversation
Contributor
|
Sorry about this! I was under the impression when I wrote this that pymatgen was for python 3.12+, thank you for fixing this! |
Contributor
Author
|
no problem at all, Lines 47 to 51 in 12011a1 Also noticed we don't test 3.10 and that's the reason this was not caught, maybe we should consider moving one of the windows configs to 3.10 |
…matgen into fix-jdftx-syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the following 3.11+ only syntax:
cc @benrich37