Remove LOBSTER output file trailing line sensitivity#4448
Merged
shyuep merged 8 commits intomaterialsproject:masterfrom Jul 29, 2025
Merged
Remove LOBSTER output file trailing line sensitivity#4448shyuep merged 8 commits intomaterialsproject:masterfrom
shyuep merged 8 commits intomaterialsproject:masterfrom
Conversation
0cb85b4 to
8b4ac3a
Compare
b92f31d to
b54bae9
Compare
b54bae9 to
1d31549
Compare
DanielYang59
commented
Jul 4, 2025
DanielYang59
commented
Jul 4, 2025
naik-aakash
reviewed
Jul 5, 2025
Co-authored-by: Aakash Ashok Naik <91958822+naik-aakash@users.noreply.github.com> Signed-off-by: Haoyu (Daniel) YANG 杨浩宇 <yanghaoyu97@outlook.com>
DanielYang59
commented
Jul 5, 2025
7f09986 to
f61d79f
Compare
f61d79f to
aa7b520
Compare
Contributor
|
Hi @DanielYang59 , thanks for this update. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cohpcarinmatgenbexample notebook:ValueError: setting an array element with a sequence.#4215str.splitlines(keepends=False):cc @JaGeo @naik-aakash