You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MP API has changed to accommodate increasingly large datasets. This PR allows for retrieving certain data objects from S3 that are no longer accessible via MongoDB
In the future, communicating which features unexpectedly no longer work, e.g., through matsci.org, is a great way to handle feature changes. Calling out the team is not going to help
I already communicated the problem to the MP team via email. Got a non helpful response.
Breaking an API with zero communication to the community (and no updates to available documentation) is a bad practice and dangerously careless to begin with.
I don't consider the commit message as "calling out the MP team". Merely stating a fact.
Can't comment other than our python client is kept up to date with the most recent database / S3 changes - if a feature set breaks, looking there is a good idea
Let's not be hyperbolic, there's no danger here. Yes, we'd love to be able to update documentation more quickly, but it's much less of a priority given time constraints than working on new data products.
Toeing the line of the code of conduct. The fact is that the same data is available, just no longer in the database for reasons of scale
The API and the python client are two separate entities. Breaking the API is even worse than breaking the python client since an end user is technically supposed to pin to a specific python dependency. An API breakage breaks even previous python clients, i.e., a backwards incompatibility that cannot be mitigated even by pinning. There is a whole literature on API versioning best practices, which was not done in this case.
Documentation and features go hand in hand. Documentation should be added/updated as new data/features are added, not patched as an afterthought when someone finds breakages in downstream code. It is 2025. If the belief is that new features are more important than documentation even in this day, we will have to agree to disagree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MP API has changed to accommodate increasingly large datasets. This PR allows for retrieving certain data objects from S3 that are no longer accessible via MongoDB
In the future, communicating which features unexpectedly no longer work, e.g., through matsci.org, is a great way to handle feature changes. Calling out the team is not going to help
fyi @mkhorton, @computron