@rkingsbury I believe this PR has reverted #4345 and updated the radii.csv accordingly. Would appreciate it if you could help me double check as I currently don't have access to a CRC handbook (we could/should work on the CSV instead of the JSON :D ).

Currently the JSON generator is still work in progress and it would not overwrite the core/periodic_table.json directly, but rather generate a temporary duplicate at dev_scripts/periodic_table_resources/_periodic_table.json. As there's still something inconsistency between the JSON and it's parser in core/periodic_table.py to be addressed around how value/unit is handled and I'm working on this.

There's a temporary JSON compare script at dev_scripts in case you want to compare two JSONs. From my side, I reverted changes to the JSON in core, and update the CSV then regenerated the temporary JSON. And AFAIK these two are the same.

Thanks @DanielYang59 ! Please connect with me via email and I can share the CRC data with you for double checking.

Note that I don't recall modifying the metallic radii in my previous PR; only the VdW ones. I'm not exactly sure about the meaning of "metallic radii".

Note that I don't recall modifying the metallic radii in my previous PR;

Ah okay I didn't noticed that thanks for remaining me!

I just tracked down the git history (JSON simply doesn't go well with version control). The "radii.csv" was added first in bec79b2 (already with "Metallic radii" data), and #1192 & #1241 directly added "metallic radii" to the JSON seemingly from a different source.

It's quite weird because the CSV data seems to come from Wikipedia and #1192 seems to refering to Wikipedia but ended up adding a different value. For example the metallic radius of K is 2.27 in CSV and wikipedia, but #1192 added a value of 2.381

I would revert changes to metallic radii to be consistent with CSV until we could verify the source from #1192

I can share the CRC data with you for double checking.

Thanks for sharing the vdw radii page. I just double checked all vdw radii, and noticed only one difference (could also be the 105th ed CRC handbook updated after the 91st ed):

• vdw radius for Pa is 2.43 in the handbook, 2.1 after Update vdW radii to CRC handbook values #2122

I can share the CRC data with you for double checking.

Thanks for sharing the vdw radii page. I just double checked all vdw radii, and noticed only one difference (could also be the 105th ed CRC handbook after the 91st ed):

• vdw radius for Pa is 2.43 in the handbook, 2.1 after Update vdW radii to CRC handbook values #2122

Great! Thank you for double checking. I'd go with the latest CRC value (2.43). A better value may have become available since the edition that I used in the previous PR.

I'd go with the latest CRC value (2.43).

Yes it has been applied in 939ea85