Skip to content

Fix mcl kpoints#4303

Merged
shyuep merged 4 commits intomaterialsproject:masterfrom
dgaines2:fix-mcl-kpath
Apr 20, 2025
Merged

Fix mcl kpoints#4303
shyuep merged 4 commits intomaterialsproject:masterfrom
dgaines2:fix-mcl-kpath

Conversation

@dgaines2
Copy link
Contributor

Fixed errors in two of the k-points for the MCL reciprocal lattice (according to Table 16 in Setyawan-Curtarolo 2010)

M2 and D1 aren't included in the recommended k-point path, but third-party software that plots k-point paths using pymatgen labelled M2 in the path instead of M1 due to it being the "same" k-point.

@mkhorton
Copy link
Member

Thanks for catching this @dgaines2! A fairly subtle bug, I hope there are not more present. Perhaps a good excuse to go back over these to be sure. Out of interest, what was the third-party software you noticed the bug in?

Including a screenshot from the paper for documentary purposes:

image

@mkhorton mkhorton enabled auto-merge (squash) April 18, 2025 05:42
@dgaines2
Copy link
Contributor Author

Thanks for reviewing this! The third-party software is sumo

@shyuep shyuep disabled auto-merge April 20, 2025 19:37
@shyuep shyuep merged commit 64da72f into materialsproject:master Apr 20, 2025
1 of 35 checks passed
@shyuep
Copy link
Member

shyuep commented Apr 20, 2025

Thanks.

@dgaines2 dgaines2 deleted the fix-mcl-kpath branch April 24, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants