Add seed: int = 0 parameter to Structure.perturb() method#4270
Merged
shyuep merged 2 commits intomaterialsproject:masterfrom Jan 28, 2025
janosh:struct-perturb-seed
Merged
Add seed: int = 0 parameter to Structure.perturb() method#4270shyuep merged 2 commits intomaterialsproject:masterfrom janosh:struct-perturb-seed
seed: int = 0 parameter to Structure.perturb() method#4270shyuep merged 2 commits intomaterialsproject:masterfrom
janosh:struct-perturb-seed
Conversation
Member
janosh
commented
Jan 27, 2025
- Update tests to verify reproducible random perturbations with same seed
- Add test cases for different seed values and min_distance parameter
- Update tests to verify reproducible random perturbations with same seed - Add test cases for different seed values and min_distance parameter
Member
|
I am confused why this is really needed. The definition of a random perturbation means it is non-deterministic. The only determinism is an inequality based on the amplitude of the perturbation. |
Member
Author
|
needed for downstream packages that use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.