Guard MSONAtoms definition behind ASE package availability#3645
Merged
janosh merged 5 commits intomaterialsproject:masterfrom Feb 23, 2024
Merged
Guard MSONAtoms definition behind ASE package availability#3645janosh merged 5 commits intomaterialsproject:masterfrom
MSONAtoms definition behind ASE package availability#3645janosh merged 5 commits intomaterialsproject:masterfrom
Conversation
Member
that 👍 |
Contributor
Author
As opposed to a linter rule that only catches my fix ;) |
9d43e87 to
0424e72
Compare
Member
|
Makes sense. Thanks! |
Contributor
Author
|
I'm actually a bit confused why |
Contributor
Author
If anyone is interested, click details below... I guess the reason is that Found 788 errors in 81 files (checked 279 source files) |
Member
|
types and we're running i realized i never bothered to check if https://github.com/RobertCraigie/pyright-python re comment, pretty sure |
Member
|
on a related note, the args: ["--ignore-missing-imports", "--scripts-are-modules"] |
Contributor
Author
|
Could we get this in then? I don't know how quickly you'd want to make another release but this does break several other packages at the moment (even just within the MP ecosystem -- atomate2, emmet, mp_api etc). Any fixing or new linting rules could be tried out in #3646 or otherwise handled by the maintainers as they see fit going forward |
2ed483c to
ef43267
Compare
Member
|
i'll take a look at this tomorrow morning. it'll definitely be in the next release. we need one for several other issues as well |
…vert MSONAtoms implementation
…whole test_ase.py module
janosh
approved these changes
Feb 23, 2024
Contributor
Author
Scratch that, misread it! LGTM |
Member
i hope not. the behavior is meant to be unchanged. given this class only raises on init, i don't see how you'd get an error on import? |
Contributor
Author
You just beat my ninja edit, in the time it took me to walk to my computer to test it out - never review PRs from your phone! Thanks for updating this @janosh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hopefully closes #3644. Not sure if this is the approach you want to take.
Todo
It would be nice to add a test or linter rule that would have caught the initial issue.