-
Notifications
You must be signed in to change notification settings - Fork 943
Closed
Description
Hi, I noticed a small typo in the comment in core/structure.py. The comment mentions "translation," but the function actually implements a "rotation" operation. (See line 4677 & 5298)
pymatgen/src/pymatgen/core/structure.py
Lines 5287 to 5299 in 153ccb4
| def rotate_sites( | |
| self, | |
| indices: Sequence[int] | None = None, | |
| theta: float = 0.0, | |
| axis: ArrayLike | None = None, | |
| anchor: ArrayLike | None = None, | |
| ) -> Self: | |
| """Rotate specific sites by some angle around vector at anchor. | |
| Args: | |
| indices (list): List of site indices on which to perform the | |
| translation. | |
| theta (float): Angle in radians |
pymatgen/src/pymatgen/core/structure.py
Lines 4664 to 4678 in 153ccb4
| def rotate_sites( | |
| self, | |
| indices: list[int] | None = None, | |
| theta: float = 0.0, | |
| axis: ArrayLike | None = None, | |
| anchor: ArrayLike | None = None, | |
| to_unit_cell: bool = True, | |
| ) -> Self: | |
| """Rotate specific sites by some angle around vector at anchor. Modifies | |
| the structure in place. | |
| Args: | |
| indices (list): List of site indices on which to perform the | |
| translation. | |
| theta (float): Angle in radians |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels