Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1376 +/- ##
===========================================
+ Coverage 85.96% 86.01% +0.04%
===========================================
Files 229 229
Lines 17888 17898 +10
===========================================
+ Hits 15378 15395 +17
+ Misses 2510 2503 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Good catch, I count 10k HSE06 Will be good to get this in the next build |
Collaborator
Author
|
Also noting that this is in support of an old client PR for retrieving blessed entries |
Collaborator
|
This should be good to go, right? Anything else need to be included here? |
Collaborator
Author
|
GTG from my side! |
tsmathis
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlessedCalcsdocument model to take inRunType.HSE06data via alias - all of this data is currentlyNonein the DB because of improper aliasingstrorRunTypetoBlessedCalcsmodel fieldemmet.core.vasp.material.MaterialsDocschema so that data (the blessed entry itself) is not lost upon deserialization