Skip to content

Remove monty decoding#1047

Merged
esoteric-ephemera merged 5 commits intomainfrom
nodec
Jan 12, 2026
Merged

Remove monty decoding#1047
esoteric-ephemera merged 5 commits intomainfrom
nodec

Conversation

@esoteric-ephemera
Copy link
Copy Markdown
Collaborator

@esoteric-ephemera esoteric-ephemera commented Dec 22, 2025 •
edited
Loading

Consistent with, and dependent on emmet-core #1372, removing monty_decode options because these are now implicitly handled by document serdes

Requires some changes to the grain boundaries and structure graph serdes in emmet, and will need to wait until a version with the fixes in 1372 is released

No breaking changes: users will be given a warning if monty_decode is used as a kwarg

Also removing some legacy, unused kwargs (supports_versions - retrieving other versions may be a future client addition)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.19%. Comparing base (2478637) to head (d40cb19).

Files with missing lines Patch % Lines
mp_api/client/core/client.py 75.00% 2 Missing ⚠️
mp_api/client/mprester.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   76.44%   76.19%   -0.25%     
==========================================
  Files          50       51       +1     
  Lines        2793     2798       +5     
==========================================
- Hits         2135     2132       -3     
- Misses        658      666       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esoteric-ephemera
Copy link
Copy Markdown
Collaborator Author

esoteric-ephemera commented Jan 9, 2026

@tschaume @tsmathis let me know if you have any concerns with removing monty_decode entirely. The way this change is implemented, a warning is thrown to the user if they specify monty_decode that the kwarg will be ignored

We could leave in functionality for monty_decode when pulling objects from S3, but this would only apply to objects which aren't currently stored as emmet models (charge densities, band structures, DOS, etc.)

Let me know what you prefer!

@tschaume
Copy link
Copy Markdown
Member

tschaume commented Jan 12, 2026

Thanks @esoteric-ephemera - looks good to me and I have no concerns about removing monty_decode entirely.

@esoteric-ephemera
Copy link
Copy Markdown
Collaborator Author

esoteric-ephemera commented Jan 12, 2026

Thanks! I'll put out an rc with these changes

@esoteric-ephemera esoteric-ephemera merged commit 30adeba into main Jan 12, 2026
4 checks passed
@esoteric-ephemera esoteric-ephemera deleted the nodec branch January 12, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tschaume tschaume tschaume approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esoteric-ephemera @codecov-commenter @tschaume