add NOTE about fields_not_requested != unset_fields

tschaume · tschaume · commit 87c072e16ea9 · 2024-12-17T14:30:21.000-08:00
diff --git a/mp_api/client/core/client.py b/mp_api/client/core/client.py
@@ -1075,6 +1075,8 @@ def _generate_returned_model(self, doc):
         data_model = create_model(  # type: ignore
             "MPDataDoc",
             **include_fields,
+            # TODO fields_not_requested is not the same as unset_fields
+            # i.e. field could be requested but not available in the raw doc
             fields_not_requested=(list[str], unset_fields),
             __base__=self.document_model,
         )

Original file line number	Diff line number	Diff line change
`@@ -1075,6 +1075,8 @@ def _generate_returned_model(self, doc):`
`1075`	`1075`	`data_model = create_model( # type: ignore`
`1076`	`1076`	`"MPDataDoc",`
`1077`	`1077`	`**include_fields,`
	`1078`	`+ # TODO fields_not_requested is not the same as unset_fields`
	`1079`	`+ # i.e. field could be requested but not available in the raw doc`
`1078`	`1080`	`fields_not_requested=(list[str], unset_fields),`
`1079`	`1081`	`__base__=self.document_model,`
`1080`	`1082`	`)`