Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

fix(infrastructure): Downgrade closure-compiler#915

Merged
lynnmercier merged 1 commit intomasterfrom
fix/closure
Jul 7, 2017
Merged

fix(infrastructure): Downgrade closure-compiler#915
lynnmercier merged 1 commit intomasterfrom
fix/closure

Conversation

@lynnmercier
Copy link
Copy Markdown
Contributor

We upgraded it with #905, but it caused tests to fail. (Unclear why these tests did no fail in TravisCI)

@lynnmercier lynnmercier requested a review from amsheehan July 7, 2017 16:54
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 7, 2017

Codecov Report

Merging #915 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          71       71           
  Lines        3323     3323           
  Branches      402      402           
=======================================
  Hits         3268     3268           
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be947f...fae5f6c. Read the comment docs.

Copy link
Copy Markdown
Contributor

@amsheehan amsheehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lynnmercier lynnmercier merged commit 5b10478 into master Jul 7, 2017
@lynnmercier lynnmercier deleted the fix/closure branch July 12, 2017 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants