Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

fix(toolbar): Fix z-index of fixed toolbars#897

Merged
yeelan0319 merged 1 commit intomaterial-components:masterfrom
trimox:fix/zindex-fixed-toolbar
Jul 6, 2017
Merged

fix(toolbar): Fix z-index of fixed toolbars#897
yeelan0319 merged 1 commit intomaterial-components:masterfrom
trimox:fix/zindex-fixed-toolbar

Conversation

@trimox
Copy link
Copy Markdown
Contributor

@trimox trimox commented Jul 3, 2017

Increased fixed toolbar's z-index from 1 to 4.

Fixes #834

Increased fixed toolbar's z-index from 1 to 4.

Fixes #834
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 3, 2017

Codecov Report

Merging #897 into master will decrease coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #897     +/-   ##
=========================================
- Coverage   98.58%   97.38%   -1.2%     
=========================================
  Files          70       70             
  Lines        3251     3251             
  Branches      393      393             
=========================================
- Hits         3205     3166     -39     
- Misses         46       85     +39
Impacted Files Coverage Δ
packages/mdc-radio/index.js 68.29% <0%> (-29.27%) ⬇️
packages/mdc-checkbox/index.js 79.24% <0%> (-20.76%) ⬇️
packages/mdc-icon-toggle/index.js 81.63% <0%> (-18.37%) ⬇️
packages/mdc-toolbar/util.js 87.5% <0%> (-12.5%) ⬇️
packages/mdc-tabs/tab/index.js 90.9% <0%> (-9.1%) ⬇️
packages/mdc-base/component.js 95.83% <0%> (-4.17%) ⬇️
packages/mdc-drawer/temporary/index.js 97.56% <0%> (-2.44%) ⬇️
packages/mdc-ripple/index.js 97.67% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8a75d...5cb7eac. Read the comment docs.

@yeelan0319 yeelan0319 merged commit 78946c4 into material-components:master Jul 6, 2017
@filipeglfw
Copy link
Copy Markdown

filipeglfw commented Jul 11, 2017

This change made Temporary Drawers (mdc-temporary-drawer has z-index of 3) open below toolbars
Should I open a bug for this issue?

NVM, there is PR to fix it #925

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MDC Switch knob rendered above the toolbar

4 participants