pluma-document: fix possible memory leak

sc0w · sc0w · commit 813e1ffd9654 · 2018-08-25T12:45:43.000+02:00
diff --git a/pluma/pluma-document.c b/pluma/pluma-document.c
@@ -656,9 +656,8 @@ file_with_bom (GFile *file)
 	FILE    *testfile;
 	gchar    c;
 	int      i;
-	gchar   *bom;
+	gchar    bom[3];
 	gchar   *file_path;
-	gboolean has_bom;
 
 	file_path = g_file_get_path (file);
 
@@ -672,27 +671,24 @@ file_with_bom (GFile *file)
 		return FALSE;
 	}
 
-	bom = "";
-
 	for (i = 0; i < 3; i++)
 	{
 		c = fgetc (testfile);
 
 		if (c == EOF)
 			break;
 		else
-			bom = g_strdup_printf ("%s%c", bom, c);
+			bom[i] = c;
 	}
 
 	fclose (testfile);
 
-	if (g_strcmp0 (bom, "\357\273\277") == 0)
-		has_bom = TRUE;
+	if ((bom[0] == '\357') &&
+	    (bom[1] == '\273') &&
+	    (bom[2] == '\277'))
+		return TRUE;
 	else
-		has_bom = FALSE;
-
-	g_free (bom);
-	return has_bom;
+		return FALSE;
 }
 
 static void
