screen: Fix use of memory after it is freed

sc0w · sc0w · commit 230f96cbd29d · 2019-03-06T12:03:16.000+01:00
Fixes Clang static analyzer warning:

core/screen.c:754:16: warning: Use of memory after it is freed
      result = g_list_prepend (result, info);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diff --git a/src/core/screen.c b/src/core/screen.c
@@ -749,9 +749,8 @@ list_windows (MetaScreen *screen)
       else
         {
 	  info->xwindow = children[i];
+          result = g_list_prepend (result, info);
 	}
-
-      result = g_list_prepend (result, info);
     }
 
   if (children)

Original file line number	Diff line number	Diff line change
`@@ -749,9 +749,8 @@ list_windows (MetaScreen *screen)`
`749`	`749`	`else`
`750`	`750`	`{`
`751`	`751`	`info->xwindow = children[i];`
	`752`	`+ result = g_list_prepend (result, info);`
`752`	`753`	`}`
`753`		`-`
`754`		`- result = g_list_prepend (result, info);`
`755`	`754`	`}`
`756`	`755`
`757`	`756`	`if (children)`