[file-manager] Fix apparent bug in context menu updating code.

Max-E · lukefromdc · commit e51b16d36919 · 2019-01-03T20:29:22.000Z
The code looked like it was supposed to check whether each file in the
selection could be opened in an external app, but was only checking the
first item in the selection repeatedly.

This bug may have been mostly benign since the subsequent call to
caja_mime_get_default_application_for_files will return NULL anyway if the
files don't all match each other.
diff --git a/src/file-manager/fm-directory-view.c b/src/file-manager/fm-directory-view.c
@@ -8811,7 +8811,7 @@ real_update_menus (FMDirectoryView *view)
 	for (l = selection; l != NULL; l = l->next) {
 		CajaFile *file;
 
-		file = CAJA_FILE (selection->data);
+		file = CAJA_FILE (l->data);
 
 		if (!caja_mime_file_opens_in_external_app (file)) {
 			show_app = FALSE;
