Fix segfault on stopping USB hard drives

lukefromdc · lukefromdc · commit df49a00d53e7 · 2018-12-03T17:39:41.000-05:00
Fix #1046 drive_stop_cb should never have used g_drive_poll_for_media_finish which is for ejectable media in a fixed drive (e.g CD drive) and not for stopping a removable drive
diff --git a/src/caja-places-sidebar.c b/src/caja-places-sidebar.c
@@ -2548,7 +2548,7 @@ drive_stop_cb (GObject *source_object,
     g_object_unref (window);
 
     error = NULL;
-    if (!g_drive_poll_for_media_finish (G_DRIVE (source_object), res, &error))
+    if (!g_drive_stop_finish(G_DRIVE (source_object), res, &error))
     {
         if (error->code != G_IO_ERROR_FAILED_HANDLED)
         {

Original file line number	Diff line number	Diff line change
`@@ -2548,7 +2548,7 @@ drive_stop_cb (GObject *source_object,`
`2548`	`2548`	`g_object_unref (window);`
`2549`	`2549`
`2550`	`2550`	`error = NULL;`
`2551`		`- if (!g_drive_poll_for_media_finish (G_DRIVE (source_object), res, &error))`
	`2551`	`+ if (!g_drive_stop_finish(G_DRIVE (source_object), res, &error))`
`2552`	`2552`	`{`
`2553`	`2553`	`if (error->code != G_IO_ERROR_FAILED_HANDLED)`
`2554`	`2554`	`{`