properties-window: fix checking inconsistent state

alexandrupandelea · lukefromdc · commit bc0b2cbb2747 · 2018-11-02T00:01:17.000-04:00
In the function initial_permission_state_consistent, when the check was made to see if the files have the same permissions, the check was not correct. To fix this, also do & between the first_permissions and the mask. https://bugzilla.gnome.org/show_bug.cgi?id=698955 Adapted from https://gitlab.gnome.org/GNOME/nautilus/commit/37595852
diff --git a/src/file-manager/fm-properties-window.c b/src/file-manager/fm-properties-window.c
@@ -3611,7 +3611,7 @@ initial_permission_state_consistent (FMPropertiesWindow *window,
 			first_permissions = permissions;
 			first = FALSE;
 
-		} else if ((permissions & mask) != first_permissions) {
+		} else if ((permissions & mask) != (first_permissions & mask)) {
 			/* Not same permissions as first -> inconsistent */
 			return FALSE;
 		}

Original file line number	Diff line number	Diff line change
`@@ -3611,7 +3611,7 @@ initial_permission_state_consistent (FMPropertiesWindow *window,`
`3611`	`3611`	`first_permissions = permissions;`
`3612`	`3612`	`first = FALSE;`
`3613`	`3613`
`3614`		`- } else if ((permissions & mask) != first_permissions) {`
	`3614`	`+ } else if ((permissions & mask) != (first_permissions & mask)) {`
`3615`	`3615`	`/* Not same permissions as first -> inconsistent */`
`3616`	`3616`	`return FALSE;`
`3617`	`3617`	`}`