[Security] eel-string: Use 'g_strlcat' instead of 'strcat'

sc0w · sc0w · commit 7a26045d9b7e · 2019-03-05T01:19:03.000+01:00
to avoid warnings with Clang Analyzer
diff --git a/eel/eel-string.c b/eel/eel-string.c
@@ -246,8 +246,8 @@ eel_str_middle_truncate (const char *string,
     truncated = g_new (char, strlen (string) + 1);
 
     g_utf8_strncpy (truncated, string, num_left_chars);
-    strcat (truncated, delimter);
-    strcat (truncated, g_utf8_offset_to_pointer  (string, length - num_right_chars));
+    g_strlcat (truncated, delimter, (truncate_length + 1));
+    g_strlcat (truncated, g_utf8_offset_to_pointer  (string, length - num_right_chars), (truncate_length + 1));
 
     return truncated;
 }

Original file line number	Diff line number	Diff line change
`@@ -246,8 +246,8 @@ eel_str_middle_truncate (const char *string,`
`246`	`246`	`truncated = g_new (char, strlen (string) + 1);`
`247`	`247`
`248`	`248`	`g_utf8_strncpy (truncated, string, num_left_chars);`
`249`		`- strcat (truncated, delimter);`
`250`		`- strcat (truncated, g_utf8_offset_to_pointer (string, length - num_right_chars));`
	`249`	`+ g_strlcat (truncated, delimter, (truncate_length + 1));`
	`250`	`+ g_strlcat (truncated, g_utf8_offset_to_pointer (string, length - num_right_chars), (truncate_length + 1));`
`251`	`251`
`252`	`252`	`return truncated;`
`253`	`253`	`}`