fm-tree-model: Fix use of memory after it is freed

sc0w · sc0w · commit 1848d37c4ddb · 2019-03-05T01:20:06.000+01:00
to avoid warning with Clang Analyzer
diff --git a/src/file-manager/fm-tree-model.c b/src/file-manager/fm-tree-model.c
@@ -779,9 +779,13 @@ stop_monitoring_directory (FMTreeModel *model, TreeNode *node)
 static void
 destroy_children_without_reporting (FMTreeModel *model, TreeNode *parent)
 {
-    while (parent->first_child != NULL)
+    TreeNode *current_child = parent->first_child;
+    TreeNode *next_child;
+    while (current_child != NULL)
     {
-        destroy_node_without_reporting (model, parent->first_child);
+        next_child = current_child->next;
+        destroy_node_without_reporting (model, current_child);
+        current_child = next_child;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -779,9 +779,13 @@ stop_monitoring_directory (FMTreeModel model, TreeNode node)`
`779`	`779`	`static void`
`780`	`780`	`destroy_children_without_reporting (FMTreeModel model, TreeNode parent)`
`781`	`781`	`{`
`782`		`- while (parent->first_child != NULL)`
	`782`	`+ TreeNode *current_child = parent->first_child;`
	`783`	`+ TreeNode *next_child;`
	`784`	`+ while (current_child != NULL)`
`783`	`785`	`{`
`784`		`- destroy_node_without_reporting (model, parent->first_child);`
	`786`	`+ next_child = current_child->next;`
	`787`	`+ destroy_node_without_reporting (model, current_child);`
	`788`	`+ current_child = next_child;`
`785`	`789`	`}`
`786`	`790`	`}`
`787`	`791`