caja-icon-container: Fix use of memory after it is freed

sc0w · sc0w · commit 0bd2d81dac01 · 2019-03-05T23:50:48.000+01:00
to avoid warning with Clang Analyzer
diff --git a/libcaja-private/caja-icon-container.c b/libcaja-private/caja-icon-container.c
@@ -7946,11 +7946,11 @@ caja_icon_container_remove (CajaIconContainer *container,
         return FALSE;
     }
 
+    g_signal_emit (container, signals[ICON_REMOVED], 0, icon);
+
     icon_destroy (container, icon);
     schedule_redo_layout (container);
 
-    g_signal_emit (container, signals[ICON_REMOVED], 0, icon);
-
     return TRUE;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7946,11 +7946,11 @@ caja_icon_container_remove (CajaIconContainer *container,`
`7946`	`7946`	`return FALSE;`
`7947`	`7947`	`}`
`7948`	`7948`
	`7949`	`+ g_signal_emit (container, signals[ICON_REMOVED], 0, icon);`
	`7950`	`+`
`7949`	`7951`	`icon_destroy (container, icon);`
`7950`	`7952`	`schedule_redo_layout (container);`
`7951`	`7953`
`7952`		`- g_signal_emit (container, signals[ICON_REMOVED], 0, icon);`
`7953`		`-`
`7954`	`7954`	`return TRUE;`
`7955`	`7955`	`}`
`7956`	`7956`