a11y: Fix crash with Orca screen reader

jascrain · raveit65 · commit 7c7c7ef28efd · 2018-04-05T17:11:43.000+02:00
ev_page_accessible_get_substring gets called with out of bounds values leading to a crash. Clamp start_offset to a valid range. https://bugzilla.gnome.org/show_bug.cgi?id=777992 origin commit: https://git.gnome.org/browse/evince/commit/?id=b34f357
diff --git a/libview/ev-page-accessible.c b/libview/ev-page-accessible.c
@@ -489,9 +489,9 @@ ev_page_accessible_get_substring (AtkText *text,
 		return NULL;
 
 	page_text = ev_page_cache_get_text (view->page_cache, self->priv->page);
-	start_offset = MAX (0, start_offset);
 	if (end_offset < 0 || end_offset > g_utf8_strlen (page_text, -1))
 		end_offset = strlen (page_text);
+	start_offset = CLAMP (start_offset, 0, end_offset);
 
 	substring = g_utf8_substring (page_text, start_offset, end_offset);
 	normalized = g_utf8_normalize (substring, -1, G_NORMALIZE_NFKC);
