Batching types instead of using individual TYPE calls#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a performance issue that was most noticably happening when ssh tunneling (due to network latency). The reason for this was I was previously calling the redis TYPE command on each key retrieved in the scan. This has been changed into a redis pipeline that will retrieve all of the types on one request rather than making many individual requests.
I have also added an option
--include-types. When set to false will not query types in bulk either (it will only query for the type once, when opening the details view). This might be benificial when connecting to production servers and to reduce latency in general.