Skip to content

Batching types instead of using individual TYPE calls#3

Merged
mat2cc merged 7 commits intomasterfrom
batch-types
Dec 28, 2023
Merged

Batching types instead of using individual TYPE calls#3
mat2cc merged 7 commits intomasterfrom
batch-types

Conversation

@mat2cc
Copy link
Copy Markdown
Owner

@mat2cc mat2cc commented Dec 23, 2023

There was a performance issue that was most noticably happening when ssh tunneling (due to network latency). The reason for this was I was previously calling the redis TYPE command on each key retrieved in the scan. This has been changed into a redis pipeline that will retrieve all of the types on one request rather than making many individual requests.

I have also added an option --include-types. When set to false will not query types in bulk either (it will only query for the type once, when opening the details view). This might be benificial when connecting to production servers and to reduce latency in general.

@mat2cc mat2cc linked an issue Dec 23, 2023 that may be closed by this pull request
@mat2cc mat2cc merged commit 59f2657 into master Dec 28, 2023
@mat2cc mat2cc deleted the batch-types branch December 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to read any keys via SSH tunnel

1 participant