refactor: Replace react-hotkeys with custom hook#35425
Merged
diondiondion merged 9 commits intomainfrom Jul 21, 2025
Merged
Conversation
ac86fe0 to
33ed884
Compare
33ed884 to
fe9a11a
Compare
Contributor
ChaosExAnima
left a comment
There was a problem hiding this comment.
this feels like a good candidate for tests. are you able to write some to cover some of these hotkeys?
renchap
reviewed
Jul 21, 2025
ChaosExAnima
previously approved these changes
Jul 21, 2025
Contributor
ChaosExAnima
left a comment
There was a problem hiding this comment.
looks good, and thank you for making the story!
ChaosExAnima
approved these changes
Jul 21, 2025
tribela
reviewed
Jul 24, 2025
Comment on lines
+129
to
+141
| cheat: sequence( | ||
| 'up', | ||
| 'up', | ||
| 'down', | ||
| 'down', | ||
| 'left', | ||
| 'right', | ||
| 'left', | ||
| 'right', | ||
| 'b', | ||
| 'a', | ||
| 'enter', | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MAS-364
Fixes #30436, #19592
Changes proposed in this PR:
react-hotkeysdependency with a custom hotkey handling hook