Allow existing Secrets to be used for secret values (#18139)#18179
Closed
tedtramonte wants to merge 1 commit intomastodon:mainfrom
Closed
Allow existing Secrets to be used for secret values (#18139)#18179tedtramonte wants to merge 1 commit intomastodon:mainfrom
tedtramonte wants to merge 1 commit intomastodon:mainfrom
Conversation
Contributor
Author
|
@dunn So, as of this comment I think I have all the They're not personally blocking me from running Mastodon, so if you'd rather leave those how they are to avoid breaking changes, that's fine with me. On the other hand, if you want them changed as part of this PR, I can probably make that happen too. Let me know one way or the other and I'll clean this up and mark it ready for review. |
Contributor
Author
|
Went ahead with avoiding any breaking changes for now and marked this ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some functions to
_helpers.tplto facilitate using the correctSecretnames throughout the chart's templates. It also adds some comments to thevalues.yamlfile indicating how to use theexistingSecretfields.Closes #18139