refactor(SyncCache): simplify ResetAsync method#750
Merged
Conversation
Replaced the `ClientQueryAsync` method with `ClientQuery().ToListAsync()` in the `ResetAsync` implementation. The `ClientQueryAsync` method and its internal logic have been removed, streamlining the asynchronous query process and improving code readability and maintainability.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ResetAsync method in the SyncCache class to simplify the asynchronous query process by replacing the ClientQueryAsync method with a more streamlined call using ClientQuery().ToListAsync().
- Replaces the ClientQueryAsync call in ResetAsync with ClientQuery().ToListAsync()
- Removes the obsolete ClientQueryAsync method and its internal aggregation logic
Comments suppressed due to low confidence (1)
src/Contrib/Authentication/OpenIdConnect/Masa.Contrib.Authentication.OpenIdConnect.EFCore/Caches/SyncCache.cs:96
- Verify that the new ClientQuery method correctly includes all required navigation properties and related data that were previously populated in the removed ClientQueryAsync method.
var clients = await ClientQuery().ToListAsync();
wzh425
approved these changes
Jun 24, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the
ClientQueryAsyncmethod withClientQuery().ToListAsync()in theResetAsyncimplementation. TheClientQueryAsyncmethod and its internal logic have been removed, streamlining the asynchronous query process and improving code readability and maintainability.