thumbnailer_shared: use full filename path for remote URLs#45
Merged
NicolaSmaniotto merged 1 commit intomarzzzello:masterfrom Sep 21, 2023
Merged
Conversation
Collaborator
|
It makes sense to consider use the whole path, but I don't like the use of the path itself as a filename (it usually contains special characters like |
The actual filename part is often similar for different URLs, so use the full path. Ensure it is always hashed to prevent bad characters from entering file names. Closes marzzzello#44
0083857 to
f4d5d40
Compare
Author
|
Good point! I've updated the PR accordingly, i.e. now the full path is still used for URLs, but any remote paths are always hashed not matter the length. |
Collaborator
|
Looks good, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual filename part is often similar for different URLs, so use the full path and let it be cleaned or hashed accordingly.
Closes #44