Skip to content

Homebrew path fix on MacOS#38

Merged
marzzzello merged 1 commit intomarzzzello:masterfrom
SemperPeritus:master
Apr 3, 2023
Merged

Homebrew path fix on MacOS#38
marzzzello merged 1 commit intomarzzzello:masterfrom
SemperPeritus:master

Conversation

@SemperPeritus
Copy link
Copy Markdown

Fix for issue #29
Works on MacOS 16.2 (MacBook Pro with M1).
mpv installed with brew. PATH contains homebrew path. Workaround in the issue.

@SemperPeritus
Copy link
Copy Markdown
Author

SemperPeritus commented Apr 2, 2023

@rucker
Can you check is works in your environment? Compiled modified version here.

@marzzzello marzzzello merged commit ca96d8c into marzzzello:master Apr 3, 2023
@marzzzello
Copy link
Copy Markdown
Owner

Thanks!

@rucker
Copy link
Copy Markdown

rucker commented Apr 4, 2023

@SemperPeritus @marzzzello Sorry, I didn't get to this fast enough! This does in fact work for my setup (M1 Mac + Homebrew), however for this to be a more complete solution I think the script should be able to locate mpv and ffmpeg somewhat more flexibly by checking other possible locations:

  1. Homebrew: Homebrew's prefix differs between Intel Macs (/usr/local/) and Apple Silicon Macs (/opt/homebrew/) (Source)
  2. Without Homebrew: mpv.app could be installed at /Applications or ~/Applications (likely the former). The mpv binary itself lives here and Homebrew symlinks to it.

Since this is already merged, what I think I'll do is submit a PR to expand on @SemperPeritus's changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants