Skip to content

General code refactoring#32

Merged
NicolaSmaniotto merged 13 commits intomarzzzello:masterfrom
NicolaSmaniotto:refactor
Jul 13, 2023
Merged

General code refactoring#32
NicolaSmaniotto merged 13 commits intomarzzzello:masterfrom
NicolaSmaniotto:refactor

Conversation

@NicolaSmaniotto
Copy link
Copy Markdown
Collaborator

@NicolaSmaniotto NicolaSmaniotto commented Nov 5, 2022

All these changes should not affect the functionality of the plugin.

Changes so far:

  • Changed how the closest thumbnail is found (useless optimization, but I don't see why not)
  • Simplified nil comparisons throughout
  • Removed some parentheses in function calls (though it may confuse someone not used to lua?)
  • Moved is_remote inside the thumbnailer
  • Make thumbnail generation depend on total thumbnails
  • Use mp.command_native

This fixes the list when thumbnail_count is a power of 2
@NicolaSmaniotto NicolaSmaniotto marked this pull request as ready for review November 7, 2022 09:27
@NicolaSmaniotto NicolaSmaniotto merged commit 21ccb89 into marzzzello:master Jul 13, 2023
@NicolaSmaniotto NicolaSmaniotto deleted the refactor branch July 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant