Add hwdec option#21
Merged
marzzzello merged 2 commits intomarzzzello:masterfrom Jul 6, 2022
NicolaSmaniotto:hwdec
Merged
Conversation
No links in markdown code blocks
Owner
|
Thanks! |
Collaborator
Author
This is strange, do you see the hardware decoder when pressing Like this: |
Owner
|
Yes, it also shows vaapi. The duration for thumbnail generation stays the same. |
Collaborator
Author
|
I see. Maybe your processor is already powerful enough to move the bottleneck elsewhere. My 4th gen i5 certainly needs the help. Have a nice day :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option for the user to choose a value for the
--hwdec=parameter for mpv subcalls.The default is kept "no", as it currently is.
From my testing, it can be enabled without issues because mpv is able to gracefully fall back to software decoding.
I personally set it to
auto-safe, and it almost halves the time to generate the thumbnails (of course, for encoders supported by my processor).