Fix network thumbnailing via playlist workaround#10
Merged
marzzzello merged 1 commit intomarzzzello:masterfrom Feb 5, 2022
Merged
Conversation
Network thumbnailing regularly fails when it needs to use the mpv playlist edl:// workaround. This commits adds a workaround for this, though it's a bit of a hack: The url added to the playlist contains a bunch of fields like `ytdl_description` that are not actually needed. Those will break the playlist if they contain newlines (which is common in youtube video descriptions, for example), or if they contain urls (the urls get picked up for some reason...). I don't know how those url are actually constructed and if it's possible to just have some fields omitted, but here we just remove the `ytdl_description` and everything that follows, and after a few days of testing it seems to consistently work.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network thumbnailing regularly fails when it needs to use the mpv playlist
edl:// workaround. This commits adds a workaround for this, though it's a
bit of a hack:
The url added to the playlist contains a bunch of fields like
ytdl_descriptionthat are not actually needed. Those will break the playlist if they contain
newlines (which is common in youtube video descriptions, for example), or if
they contain urls (the urls get picked up for some reason...).
I don't know how those url are actually constructed and if it's possible
to just have some fields omitted, but here we just remove the
ytdl_descriptionand everything that follows, and after a few daysof testing it seems to consistently work.
See #8.
That's probably not the cleanest way to do this, but it works.